Knot theory: compute_additional_segment bug - #506
Closed
zzzzzbk wants to merge 1 commit into
Closed
Conversation
zzzzzbk
requested review from
armantekinalp,
bhosale2 and
skim0119
as code owners
October 9, 2025 17:36
Collaborator
|
@zzzzzbk Hi -- Thank you for your contribution. It seems like you are just changing the order of the loop and the branching. Could you explain more detail on what you are trying to fix? Also, you are branching (if/else) at every iteration loop, which doesn't look efficient. We deliberately run loop inside the if/else statements for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The direction_of_rod_end and direction_of_rod_begin are not properly updated by timestep. All first_point/last_point are calculated based on the directions of the final timestep due to it.