Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves several critical UI and state management issues across the User and Rider applications to improve stability and UX.
Key Fixes:
Ride Completion / Rating Screen UI (Bug 5):
Refactored RatingScreen.tsx layout to use a single fluid container (KeyboardAvoidingView + flex: 1).
Removed the ScrollView that caused the primary CTA button to fall below the fold on smaller devices, keeping it safely pinned to the bottom.
Notification Popups Deduplication & Theme (Bug 7 & UI):
Implemented a robust deduplication logic in NotificationContext.tsx using useRef(new Set()). This ensures that even after a notification auto-hides after 5 seconds, duplicate events from the backend polling loop are ignored.
Restyled PopupNotifications.tsx in both FluxUser and FluxRider apps to follow the premium Flux Theme. Replaced the generic grey box with a sleek colors.bg background overlaid with CardGradient and a neon colors.accent shadow.
Duplicate Bid Submission via Polling (Available Bookings):
Fixed an issue where the AvailableBookingsScreen re-displayed bookings that the rider had already bid on, allowing duplicate bid placements.
Updated the riderSlice.ts reducers (setAvailableBookings and addBid) to automatically filter out bookings that exist in the myBids array.
Prevented currentIndex from resetting to 0 every 10 seconds during the backend polling interval, ensuring a smooth UX when skipping or interacting with bids.