fix: scope host previousRoundMachinations to a single round - #202
Merged
Conversation
Backend PR #15 changed the host-only previousRoundMachinations query to return every past round's submissions tagged with a roundNumber field, instead of just the previous round. The app never picked up the new field, so PreviousRoundMachinationsSection flattened all past rounds together, showing inflated/duplicated "Supported by" lists for hosts only (members' responses are still correctly scoped server-side and were unaffected).
Garemat
force-pushed
the
fix/previous-round-machinations-scope
branch
from
July 14, 2026 14:32
856f638 to
1f7a306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backend PR #15 in lunachron-backend changed the host-only
previousRoundMachinationsquery to return every past round's submissions (tagged with a newroundNumberfield) instead of just the previous round. The app never picked up the new field, soPreviousRoundMachinationsSectionflattened all past rounds together, inflating "Supported by" lists with duplicate names for hosts only — member responses stayed correctly scoped server-side and were unaffected.This adds
roundNumber: Int?toOnlineMachinationEntry(null when absent, i.e. for member responses) and filters entries byroundNumber == previousRoundbefore aggregating supporters/sabotages, so hosts see the same single-round data as everyone else.Checklist