fix: sort machination target list by powerPoints not matchPoints - #197
Merged
Conversation
matchPoints alone excludes mpAdjustment and inGameMp, which meant players with host-applied point corrections ranked incorrectly. powerPoints is the pre-computed total (VP + vpAdj + MP + mpAdj + igmp). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
matchPointsthenvictoryPoints, ignoringmpAdjustmentandinGameMp.mpAdjustment) or in-game MP (inGameMp) would appear at the wrong rank, causing both the rank badge and the tier-based impact hints (TOP/MIDDLE/BOTTOM) to be wrong.powerPoints(the pre-computed total already stored on the member:VP + vpAdj + MP + mpAdj + igmp).Test plan
mpAdjustmentorinGameMpvalues — confirm rank badges reflect full power points standings🤖 Generated with Claude Code