Repository navigation
feat(admin): German Branding settings page and custom domain card - #439
Open
grumpy-miner wants to merge 2 commits into
Open
grumpy-miner wants to merge 2 commits into
grumpy-miner wants to merge 2 commits into
Conversation
Slice 8 of the board card "Admin UI multi-language" (PVTI_lADOElDmdM4Bn50jzhCKGsA): Settings > Branding reads its copy from the catalog (logo, brand color with the AA check, corner radius, careers page, save, live preview caption) and so does the custom domain card under it (states, TXT record rows, copy buttons, plan notes). The preview's sample candidate copy stays English, as candidate pages are not translated yet. English is unchanged outside a LocaleProvider. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RPybyvB18ZuCx4qeFqU5UK
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RPybyvB18ZuCx4qeFqU5UK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Board card: Admin UI multi-language (PVTI_lADOElDmdM4Bn50jzhCKGsA)
Slice 8 of the card (1 #432: catalog, German shell, language picker; 2 #433: settings tabs, Account profile and password; 3 #434: sign-in methods, two-factor, sessions; 4 #435: availability and companies; 5 #436: Developers page; 6 #437: API keys and webhooks; 7 #438: Privacy page and access log). Draft card, so no
Closes.Research
app/admin/branding/page.tsx(logo, brand color with the AA badge, corner radius, careers page, save, live preview) andcomponents/CustomDomainCard.tsxunder it (claim, TXT record, verify, plan notes). TheDnsRowcopy label was built by lower-casing the English row label (Copy TXT ${label.toLowerCase()}), which cannot be translated, so it now takes an explicitcopyLabel.Plan and scope
branding.*keys (en + de): heading, logo card (hint, upload/replace/remove, size error, status messages), brand color (hint, picker/hex labels, AA badge, invalid hex), corner radius and its three options, careers page and its copy button/error, save, preview landmark, caption and timer note.customDomain.*keys (en + de): title, hint, loading/failed, verified / pending DNS badges, add/verify/remove buttons and their notices and fallback errors, Team plan and Upgrade link, TXT intro, Type/Name/Value rows, copy labels, zone hint, ownership and downgrade notes.language.partial(en + de) now lists the Branding page.In scope: the above. Out of scope (next slices): Hiring, Emails, Team, Billing settings pages, the other admin screens, server-side storage of the language, locale-aware dates/ages on other screens, candidate surfaces (card D3). The live preview's sample candidate copy ("Work at ...", job titles, "Apply for this position") stays English on purpose: it shows the candidate page, which is not translated. Server error messages stay as the server sends them.
Copy notes: formal "Sie", "Bewerberinnen und Bewerber", "Tarif" for plan, as in earlier slices; no en or em dashes.
Acceptance (this slice):
messages.test.tsparity and placeholders).Testing
pnpm typecheckOK,pnpm lint0 errors (3 pre-existing warnings),pnpm test128 files / 1260 tests passed (+6).BrandingPage in German(cards, radius options, copy button, preview landmark and caption, candidate copy kept, invalid hex + save confirmation, oversized logo error),CustomDomainCard in German(add flow with TXT rows, copy labels, Verifizieren/Entfernen; downgraded verified domain with upgrade link; load failure).git diff | md5sum(8b2151b0...) identical on both sides.🤖 Generated with Claude Code
https://claude.ai/code/session_01RPybyvB18ZuCx4qeFqU5UK
Status (run 2026-11-09 ~17:00 UTC) - blocked, needs the owner
CI (all 7 jobs), E2E and the auto-merge workflow are green and
auto_mergeis enabled, but GitHub has not merged: the ruleset requires thecla-assistantcheck, and theclaworkflow (pull_request_target) ends in startup_failure with no jobs on both pushes (runs 42652861327 at 16:15 UTC and again at 16:34 UTC after an empty re-trigger commit). The same workflow last succeeded at 15:16 UTC on #438;cla.ymland the repo's Actions permissions (all actions allowed, no SHA pinning) are unchanged, so this looks like a GitHub-side or settings issue the agent cannot see through the API. A startup_failure run cannot be re-run via the API (403). Not merged by hand and the workflow not edited, per the task rules. To unblock: open the run page for the startup error, or commentrecheckon this PR, or merge once the check is green. The card is set to In review.