Fix test_eval.py committing no files if repo checkout is named crisp - #180
Fix test_eval.py committing no files if repo checkout is named crisp#180fw-immunant wants to merge 2 commits into
test_eval.py committing no files if repo checkout is named crisp#180Conversation
I don't think this is ever the user's intent when using `crisp commit`
this ignores all files in paths starting with `crisp`, which leads to no files being committed if you happen to name your crisp-related directories "crisp" instead of Tractor-Crisp
|
The error on empty commit seems like a good idea. Can you say more about what's going on with the |
I couldn't figure out why I had so much trouble getting the
test_eval.pyscript to work locally. It turns out that it was passing a gitignore glob ofcrisp*, which included my whole checkout of the repo and all subdirectories, including the Test-Corpus directory and children.Also raise an error explicitly if we try to
crisp commitbut commit no files.