Small cleanups, mostly typing - #1
Open
fw-immunant wants to merge 4 commits into
Open
Conversation
spernsteiner
left a comment
spernsteiner
left a comment
Contributor
There was a problem hiding this comment.
What command are you using to run typechecking on this? So far I've just been adding type annotations as documentation and haven't tried actually checking them. It would be nice to have a script or at least a line in the readme saying how to run it (and later we can add it to CI as well).
kkysen
reviewed
Oct 30, 2025
Collaborator
Author
I've just been seeing errors in the Zed editor from the "basedpyright" LSP. |
fw-immunant
force-pushed
the
fw/type-cleanups
branch
from
October 31, 2025 16:46
425d766 to
0b1e73d
Compare
fw-immunant
force-pushed
the
fw/type-cleanups
branch
from
August 19, 2026 19:05
0b1e73d to
7f3ec3a
Compare
thedataking
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just from going through the repo and familiarizing myself. Should be no functional changes.