Skip to content

Codex/arabic asteroid game - #43

Merged
GalaxyRuler merged 4 commits into
mainfrom
codex/arabic-asteroid-game
May 3, 2026
Merged

Codex/arabic asteroid game#43
GalaxyRuler merged 4 commits into
mainfrom
codex/arabic-asteroid-game

Conversation

@GalaxyRuler

Copy link
Copy Markdown
Owner

Packet

  • ID:
  • Spec:
  • Claim issue:
  • Delivery note:

Summary of approach

Acceptance checklist (copy from the spec)

  • All listed files created or modified.
  • All listed tests present and passing.
  • ruff check . passes.
  • black --check . passes.
  • pytest passes on Python 3.11, 3.12, 3.13.
  • Delivery note <packet-id>.delivery.md written and committed.
  • (If aliases packet) All translation entries pass arabicpython.normalize.normalize_identifier() round-trip.
  • (If aliases packet) examples/B<NN>_<short>.apy example runs end-to-end.

Delivery note checklist

  • Deviations from the spec — every place I did something different, with reason. If "none", say "none."
  • Open questions for the planner — anything I wasn't sure about. Empty is best.
  • Non-spec testing performed — anything I tested manually that isn't in the test suite.
  • Phase A compat verifiedpytest tests/test_phase_a_compat.py passes (after B-002 merges; before then, confirm the seven examples/ files still run).

CI confirmation

  • All 9 matrix cells passing (Linux/macOS/Windows × Python 3.11/3.12/3.13).

If any cell is failing, explain why below and tag the planner — do not mark this PR ready for review.

Compatibility and generated-output statement

  • This PR does not change dictionaries/ar-v1.md. (Required per ADR 0008.B.0.)
  • If this PR changes examples/ or apps/, the changed .apy files translate/compile and any runnable examples have smoke coverage or documented optional dependencies.
  • If this PR changes Arabic terms, aliases, dictionaries, or generated docs, python tools/validate_lexicon.py and python tools/generate_lexicon_outputs.py --check pass.
  • If this PR changes an internal API in arabicpython/, the change is documented in the delivery note's "Deviations" section.

If any compatibility box is unchecked, explain the reason in the PR body before requesting review.


Reviewers: see CONTRIBUTING.md §8 for the review process. Tests are the contract — focus review on whether tests cover the spec's requirements, not on code style.

@GalaxyRuler
GalaxyRuler merged commit 3ab7330 into main May 3, 2026
9 checks passed
@GalaxyRuler
GalaxyRuler deleted the codex/arabic-asteroid-game branch May 3, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant