lint: print source line under each warning - #3585
Open
aleksisch wants to merge 2 commits into
Open
Conversation
Uses the structured *_collect_issues overloads (LintIssue carries file/line/column) instead of re-parsing locations out of display strings. --silent suppresses the source lines.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the utils/lint CLI output to include the offending source line under each warning, switching the tool to consume structured LintIssue records (file/line/column) rather than re-parsing location data from formatted strings. A new --silent flag is added to suppress the source-line printing when desired.
Changes:
- Replace string-based lint collection with
*_collect_issuesto carry structured file/line/column metadata end-to-end. - Print the corresponding source line under each unique warning (deduped), with a cache to avoid re-reading the same file repeatedly.
- Add
--silentto disable source-line printing while keeping warning summaries.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+92
to
+95
| let fin = find(text, "\n", start) | ||
| let line = fin < 0 ? slice(text, start) : slice(text, start, fin) | ||
| return line |> strip | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the structured *_collect_issues overloads (LintIssue carries file/line/column) instead of re-parsing locations out of display strings. --silent suppresses the source lines.