InteractiveArnoldRenderTest : Fix intermittent failure on macOS#7015
Open
murraystevenson wants to merge 1 commit into
Open
InteractiveArnoldRenderTest : Fix intermittent failure on macOS#7015murraystevenson wants to merge 1 commit into
murraystevenson wants to merge 1 commit into
Conversation
When testQuadLightTextureEdits is run on macOS it occasionally fails with:
```
File "/Users/runner/work/gaffer/gaffer/build/arnold/7.4/python/GafferArnoldTest/InteractiveArnoldRenderTest.py", line 349, in testQuadLightTextureEdits
self.assertAlmostEqual( self._color4fAtUV( s["catalogue"], imath.V2f( 0.5 ) ).g, 0, delta = 0.01 )
AssertionError: 0.030833924189209938 != 0 within 0.01 delta (0.030833924189209938 difference)
```
Which looks like the green channel might just need a bit more time to converge, so we now wrap this assert in an assertEventually like the other asserts in this test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testQuadLightTextureEdits is run on macOS it occasionally fails with:
Which looks like the green channel might just need a bit more time to converge, so we now wrap this assert in an assertEventually like the other asserts in this test.