GafferScene, IECoreArnold : Adapt to IECoreScene::Renderer removal#6512
Merged
Conversation
johnhaddon
force-pushed
the
cortexRendererRemoval
branch
from
97a498a to
6a1d485
Compare
Member
Author
|
Pushed an extra commit to update to GafferHQ/dependencies 10.0.0a5, which contains the Cortex version we are adapting to in this PR. |
ericmehl
approved these changes
Jul 24, 2025
ericmehl
left a comment
ericmehl
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I ran the Windows build with the updated dependencies and all looks good. Merging...
github-project-automation
Bot
moved this from Pending Review
to Pending release
in Work in Progress
Member
Author
|
Thanks Eric! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor adjustments to account for Cortex changes from ImageEngine/cortex#1477. This keeps us compatible with both Cortex 10.5 and the upcoming 10.6. I didn't bother keeping the warnings, because they are irrelevant to the official Gaffer builds we're planning, which will use Cortex 10.6 exclusively.