Ex2 solution#2
Open
luisa-beerboom wants to merge 2 commits into
Open
Conversation
GabrielInTheWorld
requested changes
Apr 1, 2022
GabrielInTheWorld
left a comment
GabrielInTheWorld
left a comment
Owner
There was a problem hiding this comment.
In general, the code looks good!
There is still something to do.
| }); | ||
| } | ||
|
|
||
| public ngOnInit(): void {} |
Owner
There was a problem hiding this comment.
Remove unused functions
| <input id="firstName" formControlName="firstName" type="text" placeholder="First Name..." autofocus> | ||
| <input id="lastName" formControlName="lastName" type="text" placeholder="Last Name..."> | ||
|
|
||
| <button type="submit" class="smolButton addUser" [disabled]="addForm.value.title==='' || addForm.value.firstName==='' || addForm.value.lastName===''">+ Add User</button> |
Owner
There was a problem hiding this comment.
Write logic in the .ts-file
Comment on lines
+35
to
+40
| if(this.addForm.value.title==null){ | ||
| this.messageService.add(`${this.addForm.value.firstName} ${this.addForm.value.lastName}`); | ||
| } | ||
| else{ | ||
| this.messageService.add(`${this.addForm.value.title} ${this.addForm.value.firstName} ${this.addForm.value.lastName}`); | ||
| } |
Owner
There was a problem hiding this comment.
You can simplify the message to only extend the "base" message by a title, if a title is provided.
Comment on lines
+9
to
+13
| { path: 'userlist', component: UserlistComponent }, | ||
| { path: 'edit', component: EditviewComponent }, | ||
| { path: 'dashboard', component: DashboardComponent }, | ||
| { path: 'detail/:id', component: UserDetailComponent }, | ||
| { path: '', redirectTo: '/dashboard', pathMatch: 'full' } |
Owner
There was a problem hiding this comment.
Every route should point to a lazy loaded module
| { path: 'userlist', component: UserlistComponent }, | ||
| { path: 'edit', component: EditviewComponent }, | ||
| { path: 'dashboard', component: DashboardComponent }, | ||
| { path: 'detail/:id', component: UserDetailComponent }, |
Owner
There was a problem hiding this comment.
Try to write for every url segment an own path
Comment on lines
+28
to
+31
| // getUsers(): void { | ||
| // this.userService.getUsers() | ||
| // .subscribe(users => this.users = users); | ||
| // } |
| }) | ||
| export class UserlistComponent implements OnInit { | ||
|
|
||
| users: BehaviorSubject<Map<number, User>> = new BehaviorSubject(new Map()); |
| @@ -0,0 +1,33 @@ | |||
| import { Component, OnInit } from '@angular/core'; | |||
| import { BehaviorSubject } from 'rxjs'; | |||
| //import { Title } from '@angular/platform-browser'; | |||
Comment on lines
+9
to
+12
| { path: 'userlist', component: UserlistComponent }, | ||
| { path: 'edit', component: EditviewComponent }, | ||
| { path: 'dashboard', component: DashboardComponent }, | ||
| { path: 'detail/:id', component: UserDetailComponent }, |
Owner
There was a problem hiding this comment.
Besides: You point with every route (except the dashboard) to a user-concerning component. Therefore, create at least a user-module and write something like this:
Suggested change
| { path: 'userlist', component: UserlistComponent }, | |
| { path: 'edit', component: EditviewComponent }, | |
| { path: 'dashboard', component: DashboardComponent }, | |
| { path: 'detail/:id', component: UserDetailComponent }, | |
| { path: '', component: UserlistComponent }, | |
| { path: 'edit/:id', component: EditviewComponent }, | |
| { path: 'detail/:id', component: UserDetailComponent }, |
| templateUrl: './editview.component.html', | ||
| styleUrls: ['./editview.component.scss'] | ||
| }) | ||
| export class EditviewComponent implements OnInit { |
Owner
There was a problem hiding this comment.
In general: Name components related to their concerns. For example: UserEditViewComponent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did it!