fix(engine): match template failure boundaries#80
Merged
Conversation
Evaluate fail arguments before throwing and treat unknown function calls with arguments as unsupported instead of rendering them as literal text. Add Helm CLI golden error fixtures for required, fail, missing function, and malformed template cases. Fixes #13. Verification: dotnet test HelmSharp.sln --configuration Release
Fail no-argument unknown functions instead of rendering them as literal text, and surface invalid substr ranges that Helm treats as slice bound errors. Verification: dotnet test HelmSharp.sln --configuration Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
failarguments before throwing so expression-based messages match Helm behavior.required,fail, missing function, and malformed template cases.[Unreleased]inCHANGELOG.md.Validation
dotnet test tests/HelmSharp.Tests/HelmSharp.Tests.csproj --configuration Release --filter FullyQualifiedName~TemplateErrorGoldenTestsdotnet test HelmSharp.sln --configuration ReleaseFixes #13