fix(engine): match Sprig string slicing#79
Merged
Conversation
Align trunc and substr behavior with Helm/Sprig for negative trunc lengths and substring end indexes. Add regression coverage and record the M1 parity fix in the changelog.
Normalize negative substr end indexes to the input length before range validation, matching Helm/Sprig's -1 sentinel behavior. Add regression coverage for full-string and tail substr calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
truncwith Helm/Sprig for negative lengths so it returns the tail of the string.substr's second argument as an end index instead of a length.[Unreleased].Why
M1 function parity tracks common Helm/Sprig behavior. Helm CLI renders
trunc -5 "hello world"asworldandsubstr 1 5 "hello world"asello; HelmSharp previously returned different results.Fixes #10
Verification
helm templatescratch chart comparison fortruncandsubstrdotnet test tests/HelmSharp.Tests/HelmSharp.Tests.csproj --filter FullyQualifiedName~TemplateFunctionTests --configuration Releasedotnet test HelmSharp.sln --configuration Release