fix(action): render before namespace creation#78
Merged
Conversation
Move new helper and documentation entries into standard Keep a Changelog sections, replace the custom Docs heading, and add version comparison links.
Move install and upgrade manifest rendering ahead of namespace creation so invalid templates fail before mutating the cluster. Add regression coverage with a fake Kubernetes client that verifies release-history lookup remains read-only and namespace creation is skipped on render failure.
GaTTGeng
force-pushed
the
fix/32-render-before-namespace
branch
from
d108182 to
35e91ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateNamespaceperforms namespace creation, so invalid templates fail before mutating the cluster..Release.IsUpgradeand revision values still reflect existing release state.POST /api/v1/namespacesis not sent after render failure.[Unreleased], normalize changelog categories to Keep a Changelog headings and add version comparison links.Fixes #32
Verification
dotnet test tests/HelmSharp.Tests/HelmSharp.Tests.csproj --configuration Release --filter "FullyQualifiedName~ChartOperationsTests"dotnet test HelmSharp.sln --configuration Release