ci: harden pipeline workflows + fix AsConfig scalar escaping#76
Merged
Conversation
Tighten CI and documentation workflow triggers, cache NuGet packages, and upload symbol packages from CI artifacts. Harden NuGet releases by rejecting v-prefixed tags, validating release tags against master, deriving assembly/file versions from the package version core, and publishing snupkg packages. Verification: dotnet pack HelmSharp.sln --configuration Release --no-restore --output C:\tmp\helmsharp-pack-test -p:PackageVersion=1.0.0-preview.1 -p:AssemblyVersion=1.0.0.0 -p:FileVersion=1.0.0.0; npm run docs:build; python YAML parse; git diff --check. dotnet test HelmSharp.sln --configuration Release --no-restore fails locally on existing Windows line-ending golden fixture files.
Keep .Files.AsConfig file content unchanged and emit quoted YAML scalars with escaped control characters, matching Helm output for multiline and CRLF files. Update template function coverage and changelog for the parity fix. Verification: focused Helm template parity filter passed; full dotnet test HelmSharp.sln Release passed.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7cd1c6af7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The previous fix (a7cd1c6) removed the YAML block scalar (|) output for multiline file content, emitting everything as quoted scalars. Helm uses block scalars for LF-only files and quoted scalars with control character escapes for CRLF files. This restores the block scalar path for files with plain LF newlines while keeping the quoted-scalar-with-escapes path for CRLF files. Co-Authored-By: Claude <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
GaTTGeng
added a commit
that referenced
this pull request
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes