Decreased RAM usage for read_mne_epochs - #327
Merged
Merged
Conversation
GWeindel
approved these changes
Aug 7, 2026
GWeindel
left a comment
GWeindel
left a comment
Owner
There was a problem hiding this comment.
Works, did it use that much RAM?
Collaborator
Author
|
I saw RAM usage going up to 78GB for this dataset while populating during the first step, at which it would need twice that (156GB) for the list comprehension. I still think 78GB is a bit much for a 35GB dataset, but this is workable at least. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered an issue that the 128GB RAM I have access to filled up when reading a 35GB dataset using
read_mne_epochs()Currently, the function keeps both the
epochsand thehmp_data_format()in memory until the list comprehension finishes, requiring at least 2x the dataset size in RAM.This fix iteratively removes the already converted epochs from memory while building the list of xr.Datasets.