Prevent overflowing of bars in tooltip renderers#66
Merged
Conversation
tiffit
requested changes
May 10, 2026
tiffit
left a comment
tiffit
left a comment
Member
There was a problem hiding this comment.
I don't think we should modify the displayed maximum as it is just hiding the actual information which can make testing/debugging more difficult. It would be better to just clamp the width of the bar to [0, 1] to fix bar going out of bounds
Contributor
tiffit
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents bars going out of the waila bounds, if for some weird reason the amount is bigger than the capacity, such as this case: https://discord.com/channels/181078474394566657/522098956491030558/1502992908045778976 - image for that: