You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The core fix looks correct. Argument-less `torch.squeeze()` drops every singleton dim, so with BS=1 the input `[1, seq_len, 1]` collapses to `[seq_len]` and the batch dimension is lost. `.squeeze(-1)` only removes the trailing dim, giving `[1, seq_len]` and preserving the batch — this is the right fix and is also safer in general.
Two follow-ups:
Same bug remains in `scripts/test_toxsmi.py:203`:
```python
yhat, pred_dict = model(torch.squeeze(x.to(device)))
```
This is the identical pattern, so inference will still break at BS=1. Suggest applying the same `.squeeze(-1)` change here so BS=1 is fixed end-to-end.
.gitignore nit (optional): the file is named `.DS_Store`, so the conventional entry is `.DS_Store` (or `**/.DS_Store`) rather than `*.DS_Store`; also missing a trailing newline.
LGTM to merge once the test script line is addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.