Support legacy souvenir loot lists#26
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesTournament metadata now flows from item schemas and RCON parameters into created items and souvenir packages. Souvenir sticker selection supports event-era formats, team/player roles, MVP autographs, and map Gold stickers. Supplemental loot lists are loaded, packaged, and documented. Tournament souvenir and loot-list support
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@csgo_gc/souvenir.cpp`:
- Around line 74-77: Update the event-format classification around
SouvenirTournament::Stockholm2021 so only explicitly recognized GoldMap events
or ranges return SouvenirFormat::GoldMap. Ensure arbitrary, invalid, and future
event IDs remain unsupported and follow the existing warning path instead of
being classified as supported.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9e387b49-1b29-4a5f-8ac9-c33152c3eeb7
📒 Files selected for processing (12)
.github/workflows/build.ymlREADME.mdcsgo_gc/gc_client.cppcsgo_gc/inventory.cppcsgo_gc/inventory.hcsgo_gc/item_schema.cppcsgo_gc/item_schema.hcsgo_gc/souvenir.cppcsgo_gc/souvenir.hdocs/rcon.mddocs/souvenirs.mdexamples/gc_loot_lists.txt
Resolve #20.
Summary
Testing
Summary by CodeRabbit
New Features
give_itemto accept tournament metadata (event, stage, team0/team1, and MVP) and apply it to created items.item_setsand legacy souvenir loot-list examples.Documentation
Chores
gc_loot_lists.txtexample.