Skip to content

Support legacy souvenir loot lists#26

Merged
GT-610 merged 6 commits into
mainfrom
fix/issue-20-legacy-souvenir-loot-lists
Jul 16, 2026
Merged

Support legacy souvenir loot lists#26
GT-610 merged 6 commits into
mainfrom
fix/issue-20-legacy-souvenir-loot-lists

Conversation

@GT-610

@GT-610 GT-610 commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Resolve #20.

Summary

  • Add support for legacy souvenir loot lists in GC item handling and schema parsing
  • Wire the new loot-list behavior through client, server, inventory, and souvenir code paths
  • Update docs, examples, build metadata, and CI to reflect the new configuration and workflow

Testing

  • Not run (not requested)
  • Covered by code changes across the GC pipeline and updated example/config documentation

Summary by CodeRabbit

  • New Features

    • Extended RCON give_item to accept tournament metadata (event, stage, team0/team1, and MVP) and apply it to created items.
    • Enhanced souvenir package sticker/metadata selection across historical formats, including updated handling of the “fourth” sticker slot (MVP autograph vs map gold).
    • Added supplemental loot-list support, including reusable item_sets and legacy souvenir loot-list examples.
  • Documentation

    • Added a new souvenirs guide and expanded RCON/config documentation with tournament parameter examples and era-specific notes.
  • Chores

    • Updated release packaging to include the supplemental gc_loot_lists.txt example.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c95f989b-316c-43f2-88d5-311495e06b7e

📥 Commits

Reviewing files that changed from the base of the PR and between 89a2fb0 and 893acd8.

📒 Files selected for processing (1)
  • csgo_gc/souvenir.cpp

📝 Walkthrough

Walkthrough

Changes

Tournament metadata now flows from item schemas and RCON parameters into created items and souvenir packages. Souvenir sticker selection supports event-era formats, team/player roles, MVP autographs, and map Gold stickers. Supplemental loot lists are loaded, packaged, and documented.

Tournament souvenir and loot-list support

Layer / File(s) Summary
Tournament schema and supplemental loot lists
csgo_gc/item_schema.*
Adds tournament metadata, updated sticker-kit lookup APIs, tournament attribute parsing, and item_sets loot-list expansion.
RCON tournament options and item attributes
csgo_gc/gc_client.cpp, csgo_gc/inventory.*
Parses tournament_* RCON parameters and applies provided values as item attributes.
Era-aware souvenir sticker selection
csgo_gc/souvenir.*
Selects souvenir sticker kits by event format and role, including MVP autograph or map Gold fourth stickers.
Loot-list distribution and usage documentation
examples/gc_loot_lists.txt, .github/workflows/build.yml, README.md, docs/rcon.md, docs/souvenirs.md
Adds example loot lists, includes them in release artifacts, and documents configuration and souvenir creation.

Possibly related PRs

  • GT-610/csgo-gc#16: Adds the RCON command infrastructure and give_item parsing path extended by these tournament parameters.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 2.86% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding support for legacy souvenir loot lists.
Linked Issues check ✅ Passed The changes add legacy GC loot-list loading and parsing to address the souvenir error with no loot list available.
Out of Scope Changes check ✅ Passed The documentation, example data, and code changes all support the same souvenir loot-list feature and do not appear unrelated.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GT-610
GT-610 changed the base branch from master to main July 16, 2026 05:36

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@csgo_gc/souvenir.cpp`:
- Around line 74-77: Update the event-format classification around
SouvenirTournament::Stockholm2021 so only explicitly recognized GoldMap events
or ranges return SouvenirFormat::GoldMap. Ensure arbitrary, invalid, and future
event IDs remain unsupported and follow the existing warning path instead of
being classified as supported.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9e387b49-1b29-4a5f-8ac9-c33152c3eeb7

📥 Commits

Reviewing files that changed from the base of the PR and between f51cd7a and 89a2fb0.

📒 Files selected for processing (12)
  • .github/workflows/build.yml
  • README.md
  • csgo_gc/gc_client.cpp
  • csgo_gc/inventory.cpp
  • csgo_gc/inventory.h
  • csgo_gc/item_schema.cpp
  • csgo_gc/item_schema.h
  • csgo_gc/souvenir.cpp
  • csgo_gc/souvenir.h
  • docs/rcon.md
  • docs/souvenirs.md
  • examples/gc_loot_lists.txt

Comment thread csgo_gc/souvenir.cpp Outdated
@GT-610
GT-610 merged commit 89ec451 into main Jul 16, 2026
5 checks passed
@GT-610
GT-610 deleted the fix/issue-20-legacy-souvenir-loot-lists branch July 16, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Souvenirs no loot list

1 participant