ci: add a branch checkup workflow - #8
Merged
Merged
Conversation
The repo has husky running lint and typecheck on commit and commitlint on the message, but nothing on the server, so a PR from a fork or a commit made with `--no-verify` went unchecked. Same shape as react-native-magic-modal's branch checkup, minus the pnpm, turbo and expo-doctor parts this repo doesn't have. Runs on PRs and on pushes to master: lint, typecheck, test, then `bob build`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a branch checkup workflow. husky runs lint and typecheck on commit and commitlint on the message, but nothing runs on the server, so a PR from a fork or a commit made with
--no-verifygoes in unchecked.Same shape as magic-modal's branch checkup, minus the pnpm, turbo and expo-doctor parts that don't apply here. Runs on PRs and on pushes to master:
yarn lint,yarn typescript,yarn test,yarn prepare. That last one isbob build, so a broken build fails the job..yarnrcpointsyarn-pathatscripts/bootstrap.js, which installs the example app and the pods when it's called with no arguments. Passinginstall --frozen-lockfilemakes it forward to yarn and stay on the library.Keeping the package. magic-toast lists magic-modal as a dependency and supplies the toast layer on top of it, so magic-modal reaching 7.1.0 doesn't replace it. magic-modal's public API is
MagicModalPortal,magicModalanduseMagicModal. magic-toast v1.0.0 shipped against magic-modal v7 with RN 0.83.6, React 19.2 and reanimated 4.3.1, and it pulled 286 downloads last month.Proof
Locally, from an empty
node_modulesandlib: