fix(docs): polish interactive demos and responsive frames - #317
Draft
GSTJ wants to merge 2 commits into
Draft
Conversation
Owner
Author
|
Preview updated for https://pr-317.react-native-magic-modal-preview.pages.dev/ Deployed QA covered:
The follow-up commit also regenerates the Fumadocs source after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
magicModal.show()andupdate()flowWhy
The first docs PR established the new site, but a few demos still looked or behaved like mockups. The close-results example also treated every dismissal as if the promise resolved after the animation, which is not how the package works. This pass makes the examples teach the real API and removes a section that did not help that explanation.
Preview
https://pr-317.react-native-magic-modal-preview.pages.dev/
Source:
39b81ee5c06d9c857db1638595453dc37dff68e8Verification
pnpm lintpnpm typecheckpnpm testpnpm formatpnpm --filter @magic-modal/docs build