Skip to content

fix(docs): polish interactive demos and responsive frames - #317

Draft
GSTJ wants to merge 2 commits into
mainfrom
agent/magic-modal-docs-polish
Draft

fix(docs): polish interactive demos and responsive frames#317
GSTJ wants to merge 2 commits into
mainfrom
agent/magic-modal-docs-polish

Conversation

@GSTJ

@GSTJ GSTJ commented Jul 29, 2026

Copy link
Copy Markdown
Owner

What changed

  • removed the release-history section that interrupted the main story
  • replaced the fake upload timer with a real magicModal.show() and update() flow
  • rebuilt the close-results lab around the package’s actual promise timing
  • added a draggable swipe interaction, an exposed mobile backdrop, and a locked first-result state
  • fixed phone proportions, the tablet example layout, scroll overlap, receipt clipping, contrast, and mobile bottom geometry

Why

The first docs PR established the new site, but a few demos still looked or behaved like mockups. The close-results example also treated every dismissal as if the promise resolved after the animation, which is not how the package works. This pass makes the examples teach the real API and removes a section that did not help that explanation.

Preview

https://pr-317.react-native-magic-modal-preview.pages.dev/

Source: 39b81ee5c06d9c857db1638595453dc37dff68e8

Verification

  • pnpm lint
  • pnpm typecheck
  • pnpm test
  • pnpm format
  • pnpm --filter @magic-modal/docs build
  • browser QA at 390×844, 768×900, and 1280×800
  • real package stack test with two concurrent entries
  • upload progress verified at an intermediate value, 100% pending, then resolved on close
  • all five close results, real swipe, snap-back, reduced motion, reset, and first-result locking
  • clean docs typecheck on Node 24 after regenerating the Fumadocs source

@GSTJ

GSTJ commented Jul 29, 2026

Copy link
Copy Markdown
Owner Author

Preview updated for 39b81ee:

https://pr-317.react-native-magic-modal-preview.pages.dev/

Deployed QA covered:

  • two real package entries, with the top notification closing while the rating promise stays pending
  • all close-result paths, including a real 100px swipe, a 40px snap-back, reset, and first-result locking
  • upload progress at an intermediate value, 100% with the promise still pending, then resolved by closing the targeted entry
  • 390px mobile geometry, full-width backdrop hit area, and no empty space below the footer

The follow-up commit also regenerates the Fumadocs source after next typegen, which removes the clean-run race found by CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant