Skip to content

Resurect viz - #469

Merged
poorva1209 merged 8 commits into
developfrom
resurect-viz
Feb 18, 2026
Merged

Resurect viz#469
poorva1209 merged 8 commits into
developfrom
resurect-viz

Conversation

@craigpnnl

Copy link
Copy Markdown
Contributor

This pull request introduces significant changes to the simulation configuration structure across the application, transitioning from a single power_system_config object to a list of power_system_configs, and refactoring related interfaces, default values, and usages throughout the codebase. Additionally, it updates several components and models to align with the new structure, adds new configuration fields, and improves how simulation and model IDs are handled in requests.

Simulation Configuration Refactor:

  • Refactored the SimulationConfiguration interface to replace the single power_system_config object with an array of power_system_configs, each containing a nested simulator_config and expanded model_creation_config fields. This change is reflected in SimulationConfiguration.ts, the default configuration, and all usages throughout the app. [1] [2]
  • Updated all code references to use power_system_configs[0] instead of power_system_config, including form population, validation, and submission in the SimulationConfigurationEditor and related components. [1] [2] [3] [4] [5] [6] [7] [8] [9]
  • Modified the SimulationVsExpectedRequest to use the new configuration structure and ensure all relevant fields are strings where appropriate.

Component and Model Updates:

  • Updated the MeasurementChartContainer and FetchLimitsFileRequest to include and utilize a model_id parameter derived from the active simulation's configuration, ensuring correct model identification in requests. [1] [2]
  • Expanded the SimulationConfigurationTabModel interface to include the new fields added to model_creation_config, such as encoding, system_frequency, triplex, etc.

Miscellaneous Changes:

  • Changed the configuration version in assets/config.json from v1.0 to develop to reflect the ongoing development state.
  • Added an optional y2 property to the Node interface for future extensibility.
  • Improved simulation queue handling by explicitly creating a Simulation instance before pushing to the queue.

These changes collectively improve the flexibility and scalability of the simulation configuration system, making it easier to support multiple power system configurations and simulators in the future.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the simulation configuration structure to support multiple power system configurations by changing from a single power_system_config object to an array power_system_configs. The refactor moves simulator_config and model_creation_config from the top-level simulation_config into individual power system configurations, enabling future support for multi-simulator scenarios.

  • Restructured SimulationConfiguration interface to use power_system_configs array instead of singular power_system_config
  • Moved simulator-specific settings into nested simulator_config within each power system configuration
  • Updated all component usages to access the first element of the new array structure using power_system_configs[0]

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
client/webpack.development.config.js Updated proxy target port from 8092 to 8080 and reformatted with consistent spacing
client/src/app/simulation/topology-renderer/TopologyRendererContainer.tsx Updated all references from power_system_config to power_system_configs[0] for topology and control operations
client/src/app/simulation/simulation-configuration-editor/views/simulation-configuration-tab/SimulationConfigurationTab.tsx Updated form initialization to access simulator and model config from new nested structure
client/src/app/simulation/simulation-configuration-editor/views/power-system-configuration-tab/PowerSystemConfigurationTab.tsx Updated dropdown selected option finders to use array notation
client/src/app/simulation/simulation-configuration-editor/models/SimulationConfigurationTabModel.ts Expanded model_creation_config with additional fields (encoding, system_frequency, triplex, etc.)
client/src/app/simulation/simulation-configuration-editor/SimulationConfigurationEditor.tsx Updated config cloning, validation, and form population to handle array structure and nested simulator_config
client/src/app/simulation/measurement-chart/models/FetchLimitsFileRequest.ts Added model_id parameter to request
client/src/app/simulation/measurement-chart/MeasurementChartContainer.tsx Updated to extract and pass model_id from active simulation config
client/src/app/expected-result-comparison/models/SimulationVsExpectedRequest.ts Restructured request body to match new config format with string types for numeric fields
client/src/app/common/topology/Node.ts Added optional y2 property to Node interface
client/src/app/common/simulation/default-simulation-configuration.ts Replaced default config structure to use power_system_configs array with nested simulator_config
client/src/app/common/simulation/SimulationConfiguration.ts Refactored interface to use PowerSystemConfig array and removed simulator settings from simulation_config
client/src/app/AppContainer.tsx Explicitly instantiated Simulation object before pushing to queue
assets/config.json Changed version from "v1.0" to "develop"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread client/webpack.development.config.js
itsMando and others added 4 commits January 6, 2026 13:56
…to simulator_config object; simulation seems to work just fine
…lationConfigurationEditor.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@poorva1209
poorva1209 merged commit 84ea87e into develop Feb 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants