Skip to content

Addition to powergrid model api to insert measurements - #1589

Closed
tdtalbot wants to merge 3 commits into
GRIDAPPSD:developfrom
tdtalbot:measurementapi
Closed

Addition to powergrid model api to insert measurements#1589
tdtalbot wants to merge 3 commits into
GRIDAPPSD:developfrom
tdtalbot:measurementapi

Conversation

@tdtalbot

Copy link
Copy Markdown
Contributor

Description

Added methods to the API to automatically insert measurements
To test this, send a request to the topic goss.gridappsd.process.request.data.powergridmodel

with the json:
{
"requestType": "INSERT_ALL_MEASUREMENTS",
"resultFormat": "JSON"
}

or:
{
"requestType": "DROP_ALL_MEASUREMENTS",
"resultFormat": "JSON"
}

We should probably have a conversation about how to set up some automated tests for this. At this time I only allow users to insert or drop measurements for all model through the api, but could add model specific calls as well if it is wanted.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@poorva1209
poorva1209 removed their request for review February 3, 2022 19:00
@poorva1209 poorva1209 removed their assignment Feb 3, 2022
@poorva1209
poorva1209 requested review from poorva1209 and removed request for poorva1209, temcdrm and tonya1 February 3, 2022 19:01
@poorva1209 poorva1209 assigned tdtalbot and unassigned temcdrm and tonya1 Feb 3, 2022
@poorva1209
poorva1209 requested review from temcdrm and tonya1 February 3, 2022 20:28
@craigpnnl

Copy link
Copy Markdown
Contributor

Closing as superseded by the same author's later PR #1686, which reworked this same measurement/house-insertion API with a cleaner design (List instead of raw base-directory strings). If the feature is still wanted, #1686 is the reference, not this earlier draft. Diff remains retrievable from this PR.

@craigpnnl craigpnnl closed this Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants