Addition to powergrid model api to insert measurements - #1589
Closed
tdtalbot wants to merge 3 commits into
Closed
Conversation
poorva1209
removed their request for review
February 3, 2022 19:00
poorva1209
requested review from
poorva1209
and removed request for
poorva1209,
temcdrm and
tonya1
February 3, 2022 19:01
Contributor
|
Closing as superseded by the same author's later PR #1686, which reworked this same measurement/house-insertion API with a cleaner design (List instead of raw base-directory strings). If the feature is still wanted, #1686 is the reference, not this earlier draft. Diff remains retrievable from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added methods to the API to automatically insert measurements
To test this, send a request to the topic goss.gridappsd.process.request.data.powergridmodel
with the json:
{
"requestType": "INSERT_ALL_MEASUREMENTS",
"resultFormat": "JSON"
}
or:
{
"requestType": "DROP_ALL_MEASUREMENTS",
"resultFormat": "JSON"
}
We should probably have a conversation about how to set up some automated tests for this. At this time I only allow users to insert or drop measurements for all model through the api, but could add model specific calls as well if it is wanted.
Fixes # (issue)
Type of change
Please delete options that are not relevant.