refactor: simplify CSVWriter into a single primary function for appending rows

[G-Rath]

When reviewing this class as part of #348, I realized there were some unused and duplicated code, but then later realized ultimately what we're using this for is locking the file to do thread safe writes, and appending rows to a csv file.

In light of that, I've ended up refactoring the class to a single public append_rows function, along with adding tests

[Copilot]

Pull request overview

This PR refactors CSVWriter to remove unused functionality, simplify row-buffering by making add_rows variadic, and adds unit tests to validate CSV output behavior.

Changes:

• Simplifies CSVWriter by removing unused methods and making add_rows(*rows) variadic.
• Updates call sites to use the new add_rows shape (including *audit_result where appropriate).
• Adds a dedicated tests/test_output.py suite covering CSV write behavior (no rows, header, BOM, multiple writes, column ordering).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
tests/test_output.py	Adds tests validating CSVWriter behavior for headers/BOM/multiple writes/column ordering.
src/output.py	Refactors CSVWriter API (variadic add_rows, simplified file writing, internal lock helper).
src/crawler.py	Updates CSV writing call sites to use the new add_rows API.
src/audit_manager.py	Updates results writing to splat list results into add_rows, and adds a (currently flawed) type annotation.

Suppressed comments (1)

src/output.py:52

• The add_rows docstring still describes a single list[...] argument, but the method is now variadic (*rows). This makes the doc misleading for callers and for generated docs.

  def add_rows(self, *rows: dict[Any, Any]) -> None:
    """Add a list of rows to the CSV row buffer.

    Args:
        rows (list[dict[Any, Any]]): list of rows of data
    """

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[G-Rath]

this isn't new, though I might address it as part of dealing with #348 (comment)

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

[G-Rath]

@copilot what's the right way to document variadic params in Python docstrings?

[Copilot]

Use the starred name in the docstring arg list, e.g. *rows (dict[str, Any]): one or more rows of data (or “variable number of row dicts”). I’ve updated append_rows to that form and tightened the type hints in commit 7fb39b5.

[G-Rath]

I asked you a question, not to do an action 🤦