feat: try waiting for shinyapps to have loaded before continuing - #169
Draft
G-Rath wants to merge 1 commit into
Draft
feat: try waiting for shinyapps to have loaded before continuing#169G-Rath wants to merge 1 commit into
G-Rath wants to merge 1 commit into
Conversation
G-Rath
force-pushed
the
improve-shiny-handling
branch
from
October 8, 2025 23:28
9387f83 to
f892efd
Compare
nzlaura
changed the title
G-Rath
force-pushed
the
improve-shiny-handling
branch
3 times, most recently
from
October 29, 2025 01:24
ef313a1 to
a6b0f34
Compare
G-Rath
force-pushed
the
improve-shiny-handling
branch
3 times, most recently
from
May 14, 2026 03:42
3911cc5 to
a9f4d12
Compare
G-Rath
force-pushed
the
improve-shiny-handling
branch
from
May 14, 2026 18:52
a9f4d12 to
8d51c76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shiny apps look to be a hybrid that relies on loading content with JavaScript after the initial load and they don't seem to be particularly fast so right now it's very common for us to end up auditing nothing unless you've manually set the page load time (which everyone tries to avoid because that means more waiting in general).
This attempts to have the browser wait for Shiny apps to finish loading before continuing by checking that the
_router_uielement has children, which looks to be where Shiny apps load their content intoResolves #136