fix out-of-bounds read in normalize_cond_str on unterminated class#691
Open
arshsmith1 wants to merge 1 commit into
Open
fix out-of-bounds read in normalize_cond_str on unterminated class#691arshsmith1 wants to merge 1 commit into
arshsmith1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
normalize_cond_str scans the members of a
[...]character class looking for the closing], but the inner loop never checks for the string terminator. When an affix file opens a class and never closes it (say a condition field of[ab), that scan runs off the end of the heap buffer holding the field, which is an out-of-bounds read and a one-byte out-of-bounds write from the min swap a few lines down. The added terminator check reports the unterminated class through the existing invalid_cond path and leaves well-formed conditions alone.Minimal repro with a two-line affix file (
xx_affix.dat):plus a matching
xx.datcontainingaffix xx, thenaspell --lang=xx --data-dir=. --local-data-dir=. --dict-dir=. create master ./xx.rws. An ASan build reports a heap-buffer-overflow in normalize_cond_str at the class scan (affix.cpp:224), reached through AffixMgr::parse_file. With the patch aspell instead printsThe condition "[ab" is invalid.