check target bounds in phonet '^^' rule handling#690
Open
arshsmith1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phonet() bounds every write to target with j < len except the one in the '^^' restart branch. Because that branch resumes at i = 0 on a word that only loses one character per pass, a rule set with
A^^mapping toXYZkeeps appending after j has already reached len, and on the eight character word AAAAAAAA ASan reports a heap write past the end of the len + 1 buffer that the to_soundslike callers hand in. Adding the same guard the two neighbouring target writes already use keeps the result truncated at len.