fix stack overflow in create_norm_table on crafted .cmap#689
Open
arshsmith1 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_norm_table sizes the stack array d from the file's N count, but the fill loop stops on the terminating "." line rather than that count, so a charset .cmap that declares a small N followed by more entry lines runs cur past the end of d. The existing sanity(cur - d == size) only runs after the loop, too late to help. Any dictionary whose charset has a matching .cmap loads this during normalization, so a crafted data file gives a stack out-of-bounds write of attacker-controlled data.
Reproduced with a .cmap declaring "N 1" then 300 "XXXX > YY" lines; ASan reports dynamic-stack-buffer-overflow (WRITE) at convert.cpp in the cur->from assignment. Bounding the loop with the same sanity() the function already uses rejects the over-long table as bad input, and valid .cmap files still load unchanged.