Fix adding track in BioNanoGenomics plugins - #1637
Open
cmdcolin wants to merge 1 commit into
Open
Conversation
cmdcolin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bugfix for jbrowse 1 for using the BioNano plugin. I did not investigate why this fixes the issue because it is somewhat odd to me, but it does
this follows up on discussions on gitter for help with cc @yumisims for Sanger/tree of life work
To test this branch, you can follow steps from https://gist.github.com/cmdcolin/b47c8e22685bf2f6ed4d982c95f164c3 and just add the added step to
git checkout fix_runtime_track_addafter the git cloneDetailed
I am not sure why there is a crash, but the "insertIndex" paramter of addChild causes it to crash for some reason https://github.com/dojo/dijit/blob/f82f5f2e6517acd0142ab19292a097072feea5dd/_Container.js#L26
The only behavior of this addChild paramter is to I believe prepend(?) to the track selector instead of append, but it is for some reason causing the crash in this case. given that it's cosmetic, I recommend adding this branch as a hotfix @yumisims