Conversation
These can fail if many with status 0 and a retry succeeds.
Collaborator
|
This is a great idea! Current code looks like it would retry forever if the fetch never succeeded, do you think it would be a good idea to limit the number of retries before failing permanently? |
Author
|
I think it depends on the status code of the request. Generally I do not think it's every wise to retry past a few attempts as the likely hood of it succeeding falls with each failed attempt :) Ideally an optimal config to allow all requests to be retried x times. We only saw the issue for features, so I came up with the "hacky" code above. There might be much simpler ways of allowing a retry and definitely a more elegant solution -- but we are Agile and this works ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At my workplace we use jbrowse, but get UI errors when fetching features due to
status:0-- it is not a CORS related thing and it occurs randomly and sometimes not at all.We implemented something like the code in this pull request to allow a single retry and it works in our cases:

These can fail if many with status 0 and a retry succeeds.
If it's relevant for your code then please incorporate it -- or perhaps make a "cleaner" way of retrying failed attempts -- especially for status: 0 -- for us it seems the browser "gives up" on certain requests.