fix(deps): patch known-vulnerable transitive dependencies - #71
Open
GFrancV wants to merge 1 commit into
Open
Conversation
Pin 16 transitive packages to their patched versions via pnpm-workspace.yaml overrides (pnpm 11 moved this setting out of package.json), resolving 46 of the 55 open security advisories, including a critical DoS in tar (pulled in through @astrojs/vercel). Left out of scope: the advisories that require a major version bump (astro 6->7, @astrojs/vercel 10->11, @hono/node-server 1->2) since those carry real breaking-change risk and need dedicated testing. Verified: pnpm audit drops from 55 to 9 open advisories (all major-bump-only), full test suite passes, and `pnpm run build` completes cleanly.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audited dependencies (Dependabot +
pnpm audit): 55 open advisories (1 critical, 18 high, 31 moderate, 5 low). This PR patches everything fixable without a major version bump, viapnpm-workspace.yamloverrides(pnpm 11 moved dependency-resolution settings out ofpackage.json'spnpmkey intopnpm-workspace.yaml).Pinned to patched versions:
tar(fixes the critical DoS advisory, pulled in through@astrojs/vercel),postcss,svgo,js-yaml,devalue,path-to-regexp,vite,hono,fast-uri,ip-address,brace-expansion,qs,yaml,esbuild,@babel/core,body-parser.Result:
pnpm auditgoes from 55 → 9 open advisories.Out of scope (left for a separate PR): the remaining 9 advisories all require a major version bump —
astro6→7,@astrojs/vercel10→11, and@hono/node-server1→2 (dev-only, viashadcn). These carry real breaking-change risk for the core framework/adapter and need dedicated build/dev/deploy testing before merging.pnpm-workspace.yaml. If PR #70 (chore/pnpm-workspace-config, which also adds this file forallowBuilds) merges first, this PR will need a rebase to merge theoverridessection in on top.Test plan
pnpm audit— 55 → 9 open advisories, all require major bumps intentionally left out of scopenpx vitest run— 115/115 tests passpnpm run build— completes successfully with the updated dependency tree