fix(release): switch to GHCR-only via docker-release-ghcr.yml#88
Merged
Conversation
The previous `docker-release.yml` setup tried to push the same `docker-paths` to both `abc.docker-registry.gewis.nl` and ghcr.io, but `eou/plankapi` only makes sense on the internal registry — GHCR routes by GitHub org, so `ghcr.io/eou/plankapi` is rejected with "permission_denied: The requested installation does not exist". Drop the internal registry entirely and switch to the dedicated `docker-release-ghcr.yml` workflow with the org-namespaced path `gewis/plankapi`. No registry secrets needed (uses GITHUB_TOKEN).
JustSamuel
force-pushed
the
fix/split-release-jobs
branch
from
8567310 to
e42200d
Compare
JustSamuel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release for v1.3.0 failed at the GHCR push:
```
ERROR: failed to push ghcr.io/eou/plankapi:latest:
denied: permission_denied: The requested installation does not exist.
```
`docker-release.yml` reuses the single `docker-paths` for both the custom registry and GHCR. `eou/plankapi` is correct on `abc.docker-registry.gewis.nl` (team namespace) but invalid on GHCR — GHCR routes by GitHub org, and there's no `eou` org.
What
Drop the internal registry entirely and switch to the dedicated GHCR-only workflow with the org-namespaced path:
```yaml
release:
uses: GEWIS/actions/.github/workflows/docker-release-ghcr.yml@v1
with:
projects: '["."]'
docker-paths: '["gewis/plankapi"]'
version: ${{ needs.versioning.outputs.next-version }}
```
Test plan