fix(release): split docker push into internal + ghcr jobs#87
Merged
Conversation
The GEWIS docker-release workflow now strictly JSON.parses the `projects` and `docker-paths` inputs (`SyntaxError: Unexpected token ', "['.']" is not valid JSON`). YAML-double-quoted strings containing single-quoted JSON aren't valid JSON. Switch to single-quoted YAML wrapping double-quoted JSON arrays, matching the example in GEWIS/actions README.
JustSamuel
force-pushed
the
ci/release-quoting
branch
from
62552e0 to
8877766
Compare
JustSamuel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release on `feat: force release` failed at the GHCR push:
```
ERROR: failed to push ghcr.io/eou/plankapi:latest:
denied: permission_denied: The requested installation does not exist.
```
`docker-release.yml` reuses the single `docker-paths` for both the custom registry and GHCR (when `github-registry: "true"`). `eou/plankapi` is correct on the internal registry but invalid on GHCR — GHCR routes by GitHub org, and there's no `eou` org (the repo is under `github.com/GEWIS`).
What
Modern GEWIS/actions (since the 2026-03-31 `feat: add reusable release-pr and flexible docker workflows`) exposes a dedicated `docker-release-ghcr.yml` with its own `docker-paths`. So split the existing single `release` job into two parallel jobs:
Also includes the JSON-quoting fix (`'["."]'` instead of `"['.']"`) so the GEWIS workflow's strict `JSON.parse` accepts the inputs.
`fix:` type is intentional — guarantees semantic-release computes a patch bump and triggers a release on merge to main.
Test plan