Feature/acollow/contributingguidelines - #379
Open
acollow wants to merge 6 commits into
Open
Conversation
Specify instructions for regression testing to be completed prior to submitting a PR.
acollow
added
the
0 diff
Member
|
Just because I might forget about this. This is a PR I made long ago to GEOSgcm_GridComp (that was then unmerged because of reasons) that added a PR template: Maybe something like this can be added here in GOCART once we know what is desired. |
Contributor
Author
Ah interesting! @vbuchard was also mentioning something that JCSDA does that she wanted to try to make sure people follow the guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds additional detail to the contributing guidelines on the testing that must be performed on zero diff PRs prior to submission.