Fixes in routing model for gcc 15 - #1479
Merged
Merged
Conversation
gmao-rreichle
added
0 diff
mathomp4
approved these changes
Jul 15, 2026
gmao-rreichle
marked this pull request as ready for review
July 16, 2026 17:18
mathomp4
self-requested a review
July 16, 2026 17:33
mathomp4
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for routing model needed by GNU compiler gcc15.
Trivially zero-diff for GCM simulations (b/c routing model is not yet used in GCM tests)
Zero-diff for GEOSldas when using Intel compiler (confirmed by @gmao-rreichle on 16 July 2027; this test evaluated the changes in the present PR in isolation, i.e., without GEOS-ESM/GEOSldas#864; adding GEOSldas PR#864 is not zero-diff).
For GNU, testing was only done in conjunction with the changes in GEOS-ESM/GEOSldas#864, with the expected non-zero diff ("roundoff") result.
Related PRs:
GEOS-ESM/GEOSldas#864
cc: @biljanaorescanin @weiyuan-jiang