v12: Update GOCART RRTMG/RRTMGP handling for new defaults - #878
Draft
mathomp4 wants to merge 2 commits into
Draft
Conversation
Now that GOCART defaults to RRTMGP optics (GEOS-ESM/GOCART#389), the @RRTMGP_RADIATION sed block (RRTMG->RRTMGP) is a no-op and has been removed. Replace with @RRTMG_RADIATION block that downgrades RRTMGP->RRTMG for L72 runs which use RRTMG radiation.
Member
Author
|
Note: This PR depends on GEOS-ESM/GOCART#389 merging first. |
mathomp4
added
0 diff
|
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
1 similar comment
|
This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When GEOS-ESM/GOCART#389 is merged, GOCART will default to RRTMGP optics. At that point, the
@RRTMGP_RADIATIONsed block that convertedRRTMG→RRTMGPin instance rc files at runtime becomes a no-op and has been removed.In its place, a
@RRTMG_RADIATIONblock is added that downgradesRRTMGP→RRTMGfor L72 runs, which use RRTMG radiation.Files changed
gcm_run.jgcm_run_benchmark.jgcm_run.j-new_rst_approachgcm_regress.jgcm_forecast.tmplDependencies