Skip to content

Fixes #316. Remove archaic code - #317

Open
mathomp4 wants to merge 3 commits into
developfrom
feature/316-clean-archaic-code
Open

Fixes #316. Remove archaic code#317
mathomp4 wants to merge 3 commits into
developfrom
feature/316-clean-archaic-code

Conversation

@mathomp4

Copy link
Copy Markdown
Member

Closes #316

This removes old geos4 era code from Chem_Shared. Per @mmanyin in #316:

We should eliminate DOING_GEOS5. And delete the file Chem_UtilMod_geos4.F90. And delete the unit test ut_mpread.F90. And delete the section in Chem_UtilMod.F90 bounded by #ifdef USE_MAPL_MPREAD. Did you want me to follow up on this?

@mathomp4 mathomp4 self-assigned this May 12, 2026
@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label May 12, 2026
@mmanyin

mmanyin commented May 12, 2026

Copy link
Copy Markdown
Contributor

@mathomp4 Since we are removing Chem_UtilMPread, please also remove the unit test for that routine Shared/Chem_Shared/ut_mpread.F90

@mathomp4

Copy link
Copy Markdown
Member Author

@mathomp4 Since we are removing Chem_UtilMPread, please also remove the unit test for that routine Shared/Chem_Shared/ut_mpread.F90

Whoops. Forgot to git rm that! Done.

@mmanyin mmanyin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to clean this up.

@mathomp4
mathomp4 marked this pull request as ready for review May 14, 2026 14:31
@mathomp4
mathomp4 requested review from a team as code owners May 14, 2026 14:31
mmanyin
mmanyin previously approved these changes May 14, 2026

@mmanyin mmanyin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Are we ever not DOING_GEOS5?

2 participants