Feature/acollow/qfed3yaml - #6
Merged
Merged
Conversation
Contributor
|
@collow, Allie (GSFC-610.1)[UNIVERSITY OF MARYLAND BALTIMORE ***@***.***> I don’t understand how the starting dates are chosen. For example, in top level ACHEM_ExtData.yaml the new files start at 2026-01-15T12:00:00 but the samplings start on the new collection on 2026-02-01T12:00:00. Why that?
Also, for NH3_EMIS_FIRE in AMIP/ACHEM_ExtData.yaml the second sampling (using 061 QFED) starts 2000-03-01T00:00:00 while for all other cases it would start at T12:00:00. Suggest you make consistent.
From: Allie Collow ***@***.***>
Date: Wednesday, March 4, 2026 at 10:18 AM
To: GEOS-ESM/ACHEM ***@***.***>
Cc: Colarco, Peter R. (GSFC-6140) ***@***.***>, Review requested ***@***.***>
Subject: [EXTERNAL] [BULK] Re: [GEOS-ESM/ACHEM] Feature/acollow/qfed3yaml (PR #6)
CAUTION: This email originated from outside of NASA. Please take care when clicking links or opening attachments. Use the "Report Message" button to report suspicious messages to the NASA SOC.
@acollow<https://github.com/acollow> requested review from @GEOS-ESM/achem-team<https://github.com/orgs/GEOS-ESM/teams/achem-team> on: GEOS-ESM/ACHEM#6<#6> Feature/acollow/qfed3yaml as a code owner.
—
Reply to this email directly, view it on GitHub<#6 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANW73YHMUAUOGXQOQCZFIDT4PBCNBAVCNFSM6AAAAACWGZCNBOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRTGI3DIMJUHE3DKNI>.
You are receiving this because your review was requested.
|
Contributor
Author
|
Pete, agreed that the time should be 12:00, so I have updated accordingly. The start dates are somewhat arbitrary. We have NRT data beginning 1/15 but I felt more comfortable beginning with the start of a month. Once testing is complete we will need to update that date again to reflect the actual date that FP gets upgraded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates ACHEM_Extdata.yaml to use QFED3 emissions once data is available for OPS and AMIP emissions. There is a corresponding PR under GOCART to do the same for aerosols.