fix(peer): improve directory picking and recover transient disconnects - #2893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Peer Device Mode directory picking and recovery from transient connectivity failures.
Type and Areas
Type: bug fix / UI/UX
Areas: Web UI, Peer Device Mode, shared system service, desktop/Tauri and CLI system-info adapters, locales, architecture documentation.
Motivation / Impact
Opening a project on a peer previously started in an existing workspace or a filesystem root, and clicking its address replaced the full-width display with a short input. The picker now uses the peer's home directory and one stable input.
A brief absence from relay presence, or several failed product RPCs, could previously switch the UI back to the local device. Transient failures now retain the remote context while recovery continues; explicit disconnect, switching device, and logout retain their existing behavior.
Verification
Passed focused checks:
check:webpassed after the fix.Reviewer Notes
The shared system service supplies an optional home directory through existing desktop and CLI
get_system_inforesponses. Older peers without this field get an explicit unavailable hint and can still navigate by entering a path; the picker never falls back to the controller's filesystem. Recovery uses the existing ping and attach protocol without new wire requirements or persisted state changes.AI-assisted contribution. Testing level: fully tested for the focused behavior described above; cross-platform and other remote-scenario coverage is limited as noted.
Checklist