Feature/forky/open furios gallery#25
Open
Joas329 wants to merge 7 commits into
Open
Conversation
…ry manager singleton. Signed-off-by: Joaquin Philco <joaquinphilco@hotmail.com>
Signed-off-by: Joaquin Philco <joaquinphilco@hotmail.com>
Signed-off-by: Joaquin Philco <joaquinphilco@hotmail.com>
Signed-off-by: Joaquin Philco <joaquinphilco@hotmail.com>
Signed-off-by: Joaquin Philco <joaquinphilco@hotmail.com>
Signed-off-by: Joaquin Philco <joaquinphilco@hotmail.com>
Contributor
|
I like this change, removes duplicate work on a gallery type system. Seems to be working correctly on my side. One improvement would probably be to add a open into the camera library itself instead of the overview. So in this case open into the furios-camera library. |
Contributor
|
whats the status of this? is it draft? |
… delete obsolete functions related to getMediaEpochMs. Signed-off-by: Joaquin Philco <joaquinphilco@hotmail.com>
Collaborator
Author
|
It seems to work properly so far. It deletes a bunch of code since the gallery app takes care of everything related to media as the Luigi mentioned. Tho the opening straight into "furios-camera" is not there yet. Moreover, it needs the edit-view PR from gallery in tandem to work properly. Otherwise, gallery wont open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting rid of the obsolete mediaView and open FuriOSGallery.
To properly test this, you are going to need this PR as well:
FuriOS Gallery - Edit View