Re-enable checks for final access.#415
Open
EliteMasterEric wants to merge 12 commits into
Open
Conversation
4a16687 to
ba2cdee
Compare
Member
Author
|
Oh yeah if you're wondering why it's a draft right now it's because it doesn't fucking work |
Member
Author
It works now! I mainly wrote this to help clean up FunkinCrew/Funkin#7238, so we can rewrite the variables to recycle them without the scripts being able to edit them from the outside. Definitely should get some review from contributors but this should prevent people from accidentally messing with constants when they aren't supposed to. An aside, this should be good to merge as-is, but in a future PR it might be nice to add functional metadata that, when applied to a class/method/block, skips this check (in a similar manner to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

finalvariables in scripts.nullorneversetters (Haxe never allows assignment tonever, and only allows local assignment tonull).finalconstants from Haxe code. This prevents issues like being able to re-assign values despite them being defined as immutable constants.