Add STAR aligner CLI parsing and reference validation - #15
Closed
Fuki-Kudoh wants to merge 1 commit into
Closed
Conversation
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
--aligner {none,star}to therunCLI with defaultnone, preserving legacy/omitted-flag behavior and existing--quantifiersemantics (src/wulfrna/cli.py).validate_reference()to acceptalignerand to validate astar_index/directory under the resolved reference only when--aligner staris selected, and to raisePipelineError(step="reference_check")on missing/unsupported aligner cases (src/wulfrna/pipeline.py).alignerinto the run manifest and conditionally recorded the STAR reference path when applicable (src/wulfrna/pipeline.py).tests/test_cli.py) and reference validation behavior for default/STAR/unsupported aligners (tests/test_reference_validation.py), plustests/conftest.pyto makesrc/importable during tests.Testing
pytestinitially which errored due to import path issues: the run showed aModuleNotFoundError: No module named 'wulfrna'during collection, sotests/conftest.pywas added to fix imports; after thatpytestpassed.pytest-> "7 passed in 0.17s".python -m compileall src/wulfrna-> completed successfully (compiled package sources).PATH="$tmp/bin:$PATH" PYTHONPATH=src python -m wulfrna.cli --help >/tmp/wulfrna_help.out-> help printed successfully.PATH="$tmp/bin:$PATH" PYTHONPATH=src python -m wulfrna.cli run "$tmp/work" --reference "$tmp/ref" --stranded reverse --threads 4 --dry-run >/tmp/wulfrna_salmon.out-> Salmon dry-run smoke test completed successfully.PATH="$tmp/bin:$PATH" PYTHONPATH=src python -m wulfrna.cli run "$tmp/work" --reference "$tmp/ref" --stranded reverse --threads 4 --quantifier kallisto --dry-run >/tmp/wulfrna_kallisto.out-> Kallisto dry-run smoke test completed successfully.PATH="$tmp/bin:$PATH" PYTHONPATH=src python -m wulfrna.cli run "$tmp/work" --reference "$tmp/ref" --stranded reverse --threads 4 --aligner star --dry-runwithstar_index/present -> STAR-reference validation passed.star_index/-> process exited with code 1 and printed the expected error:Reference directory is missing required files: /tmp/<tmpdir>/ref/star_index(caught asPipelineErrorand written to status).Note: package version was not changed and STAR execution was not implemented in this PR as requested.
Codex Task