Skip to content

chore(docker): native multi-arch via shared workflow - #156

Open
gondoi wants to merge 5 commits into
masterfrom
feature/devops-1249-enable-multi-arch-build-containers-group-2
Open

chore(docker): native multi-arch via shared workflow#156
gondoi wants to merge 5 commits into
masterfrom
feature/devops-1249-enable-multi-arch-build-containers-group-2

Conversation

@gondoi

@gondoi gondoi commented May 27, 2026

Copy link
Copy Markdown

Summary

  • Migrate container builds to FuelLabs/github-actions/.github/workflows/docker-build-push.yml@master
  • Native multi-arch: linux/amd64 + linux/arm64 (ubuntu-latest / ubuntu-24.04-arm)

Test plan

  • CI passes on PR (amd64 + arm64 build jobs)
  • Image manifest lists both architectures after merge

Part of DEVOPS-1249 / Move to graviton.

Depends on github-actions master with checkout/LFS inputs (DEVOPS-1248).

Made with Cursor

Co-authored-by: Cursor <cursoragent@cursor.com>
@cursor

cursor Bot commented May 27, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes release and PR CI paths and depend on an external reusable workflow at master; runtime app logic is unchanged but a broken or mismatched workflow could block merges or publish wrong images.

Overview
CI now delegates container build and push to the shared FuelLabs/github-actions docker-build-push workflow instead of inline Buildx steps. Images are built for linux/amd64 and linux/arm64 (native runners), published to ghcr.io, and the image job also runs on pull requests (not only master / manual dispatch).

PR frontend tests no longer build into a local registry: they depend on build-and-publish-image, log in to GHCR, pull the built image by digest (linux/amd64), and run it for npm build/test.

The Dockerfile build stage base image moves from Rust 1.82 to 1.86 (cargo-chef). The workflow drops the top-level REGISTRY env var in favor of inputs on the reusable workflow.

Reviewed by Cursor Bugbot for commit 27958cc. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread .github/workflows/ci.yml
Registry is set on the shared docker-build-push call; workflow-level
REGISTRY was only used by the removed inline docker login step.

Co-authored-by: Cursor <cursoragent@cursor.com>
Charcoal deps (indexmap 2.14) require edition2024; Cargo 1.82 in the
1.82 image cannot compile them on native arm64/amd64 builds.

Co-authored-by: Cursor <cursoragent@cursor.com>
Build multi-arch on pull_request via docker-build-push; frontend job
pulls the published amd64 digest from GHCR instead of a local registry.

Co-authored-by: Cursor <cursoragent@cursor.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fb6055c. Configure here.

Comment thread .github/workflows/ci.yml Outdated
Checkout first; single NPM build and test step with env/run block.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant