Bind ZAP1 verifier roots to leaf count and add equivalence corpus#2
Merged
Conversation
e443444 to
d086a52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stack completes the count-bound verifier cleanup and makes the verification boundary mechanically checkable across Python, Rust, and TypeScript-family code.
What changed
Why
The previous raw-root verifier surface could not distinguish some legacy odd-leaf tree shapes and left room for server/verifier drift. This PR makes the count-bound verifier path the default, preserves explicit historical legacy compatibility, and adds CI coverage so Python, Rust, and TypeScript-family verifier implementations stay aligned.
Validation
git diff --check HEAD~4..HEADnode --check equivalence\typescript\fingerprint.mjsequivalence/fingerprints.expected.txtpython conformance\zip1243_conformance.py->82/82 passed, 0 failed, 2 skippedpython verify_proof.py --proof examples\proof_bundle_example.jsonpython examples\verify_proof.py examples\proof_bundle_example.jsonpytest -q scripts\check_anchor_liveness_test.py->4 passedcargo test --manifest-path zap1-verify/Cargo.toml --offline->24 passedcargo test --manifest-path zcash-memo-decode/Cargo.toml --offline->23 passedpython conformance\check_api.py https://api.frontiercompute.cash->26 pass, 0 failpython examples\conformance_check.py https://api.frontiercompute.cash->19 pass, 0 failNotes
Strict anchor liveness remains operationally red because anchoring is paused: current state observed locally was
needs_anchor=true,unanchored_leaves=1, last anchor age about1282h. Relaxed monitor mode still reports this as a warning. This PR does not broadcast anchors, restore seed material, or mutate production service state.