Remove playwright-core override and update acceptance test suite - #5
Merged
Conversation
acceptance-test-suite 12.13.3 declares @playwright/test as a peerDependency (shopware/acceptance-test-suite#649) instead of a direct dependency, so the suite reuses the consumer's copy rather than pulling its own. That leaves a single deduped playwright-core, making our manual override pin and the suite-side type-import workaround redundant. - bump @shopware-ag/acceptance-test-suite floor to ^12.13.3 - remove the playwright-core "overrides" pin - import Page/Locator types from @playwright/test again Verified: `npm ls playwright-core` shows one deduped 1.60.0 and `tsc --noEmit` passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CUX2Soz8JvXDpBpaNxXG84
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplified the Playwright configuration by removing the
playwright-coreoverride and updating the acceptance test suite dependency. This change allows the project to use the standard Playwright type resolution instead of relying on a sharedplaywright-corecopy.Key Changes
@shopware-ag/acceptance-test-suitefrom^12.6.0to^12.13.3playwright-coreversion override frompackage.jsonthat was pinning it to1.60.0dashboard.page.tsto importPageandLocatortypes directly from@playwright/testinstead of from the acceptance test suiteImplementation Details
The previous setup required importing Playwright types from the acceptance test suite to ensure both the suite and
@playwright/testused the sameplaywright-corecopy, preventing type resolution conflicts. With the updated acceptance test suite version, this workaround is no longer necessary, allowing for a cleaner and more standard Playwright type import pattern.https://claude.ai/code/session_01CUX2Soz8JvXDpBpaNxXG84