refactor(core): rexstan + namespace baseline - #87
Open
skerbis wants to merge 2 commits into
Open
Conversation
This was referenced Aug 11, 2026
There was a problem hiding this comment.
Pull request overview
This PR is the first step of the 2.0.0 core refactor to establish a namespace baseline and adjust addon boot/install/update logic for rexstan/PHPStan compatibility and newer REDAXO versions.
Changes:
- Introduces
FriendsOfREDAXO\StructureTweaksnamespace and adds type hints / safer SQL parameter binding in core classes. - Updates backend injection scripts (adds CSP nonce) and modernizes meta-info handling.
- Adjusts packaging + install/update execution paths for the 2.0.0 line.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| update.php | Adds lib loading in update context to ensure classes are available during update runs. |
| package.yml | Bumps to 2.0.0, updates requirements, and tweaks backend page/subpage configuration. |
| lib/move_metainfo.php | Namespacing + typing, safer SQL binding, and some runtime guards. |
| lib/move_metainfo_to_tab.php | Namespacing + typing, moves meta-info handling to DOM HTMLDocument approach. |
| lib/hide_startarticle.php | Namespacing + typing; CSP nonce added to injected script. |
| lib/hide_category_functions.php | Namespacing + typing; CSP nonce added to injected scripts; simplifies legacy handling. |
| lib/category_splitter.php | Namespacing + typing; CSP nonce added; emits splitter config to JS. |
| lib/base.php | Namespaces base class and adds typing/return shaping for shared helpers. |
| install.php | Uses __DIR__ to include update on reinstall. |
| boot.php | Adds use imports and simplifies meta-info config toggle logic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
Addressed Copilot review comments in follow-up commit
Stack branches were rebased afterwards to keep the chain consistent:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of stacked PRs for #86.
Scope:
Solved issues:
How and why:
PAGES_PREPARED, saubere Sidebar-Entkopplung, stabilere Context/ctype-Guards).JSON_HEX_*) und Namespace-/Legacy-Kompatibilität für den Übergang innerhalb des Stacks.Base:
masterNext stacked PR:
stack/02-backend