Add new functions#2
Open
eminetto wants to merge 2 commits into
Open
Conversation
Closed
FrenchBen
requested changes
Oct 12, 2018
FrenchBen
left a comment
FrenchBen
left a comment
Owner
There was a problem hiding this comment.
I'd like the ability to retain our debugging for this package.
Ideally we should have:
- More debugging
- Tests 👼
Owner
|
If anything, it'd be good to see tests associated with your latest function addition. (don't want you to take on the whole thing) |
eminetto
commented
Oct 16, 2018
| @@ -0,0 +1,56 @@ | |||
| package godisco | |||
eminetto
commented
Oct 16, 2018
| @@ -0,0 +1,15 @@ | |||
| package godisco | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.