Skip to content

Added ability to require contact has hats.#65

Open
yanniboi wants to merge 5 commits into
8.x-1.xfrom
feature/tab-hats
Open

Added ability to require contact has hats.#65
yanniboi wants to merge 5 commits into
8.x-1.xfrom
feature/tab-hats

Conversation

@yanniboi

Copy link
Copy Markdown
Collaborator

No description provided.

@yanniboi

Copy link
Copy Markdown
Collaborator Author

selection_227

selection_228

@andrewbelcher andrewbelcher left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of bleed from #63.

I'm inclined to hold off on this until we've decided what we are doing with roles/hats, though the add form would be good to put in separately.

I also wonder whether we should investigate how ctools/panels does it's access. Something like D7's CTools visibility/access stuff may be more suitable than a simple 'any hat' filter...

sequence:
type: contacts.block_plugin.[id]
label: 'Blocks'
label: 'Block'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should be in #63.

@yanniboi yanniboi changed the base branch from feature/tab-blocks to 8.x-1.x October 20, 2017 15:33
@jamieaa64

Copy link
Copy Markdown

Things we want to add:

  • Ability to make some roles "Contact Types" and some not. New roles by default are on
  • Roles need to be hierarchical with parents, in a similar manner to how we have it in D7. (If you have one below you get the top one ticked as well)
  • We need to get the colours in/ icons for all roles.
  • Need to put this code in a "crmtools" thing because most of this stuff with roles could be usable without contacts

I think yan had some thoughts on this one.

@andrewbelcher

andrewbelcher commented Nov 24, 2017

Copy link
Copy Markdown
Collaborator

@yanniboi Jamie's tasks here are done in #67, so now we need to update this accordingly:

  • Show only contact type roles
  • Show their icons
  • Show their hierachy

Probably want a contact type element which does all of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants