Added ability to require contact has hats.#65
Open
yanniboi wants to merge 5 commits into
Open
Conversation
Collaborator
Author
andrewbelcher
requested changes
Oct 17, 2017
andrewbelcher
left a comment
Collaborator
There was a problem hiding this comment.
Bit of bleed from #63.
I'm inclined to hold off on this until we've decided what we are doing with roles/hats, though the add form would be good to put in separately.
I also wonder whether we should investigate how ctools/panels does it's access. Something like D7's CTools visibility/access stuff may be more suitable than a simple 'any hat' filter...
| sequence: | ||
| type: contacts.block_plugin.[id] | ||
| label: 'Blocks' | ||
| label: 'Block' |
1dce8ed to
9569d4b
Compare
|
Things we want to add:
I think yan had some thoughts on this one. |
Conflicts: src/Form/ContactTabForm.php
9569d4b to
01a5eb8
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.