[1.0.0] Address some subsearch scaling issues for the server.#209
Merged
Conversation
…ort-circuits candidate materialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the size of the directory scales (1k -> 10k -> 30k) the performance for subsearch server side starts to drop. That is due to PDO sub queries needing having broad selects / scans even though there's always a LIMIT set on the outer query. This addresses two of those cases, but a few still exist that I need to follow up on. I've added additional search types to the load test to validate them.
Most search types are actually either sub-ms or 1 - 2 ms. However, subsearch is basically flat and lands anywhere from 15 - 25 ms (when the search limit is hit + max attributes are selected), and that's largely encoding / decoding time with ASN1. I can perhaps optimize some of that a bit more (but it will be ugly). So these fixes just make sure that timing stays flat rather than balloons when directory size goes up. Current search performance is "acceptable" IMO.